Skip to content

[MLX] Add aten.bitwise_or op handler#19869

Open
devin-lai wants to merge 1 commit into
pytorch:mainfrom
devin-lai:mlx-add-bitwise-or
Open

[MLX] Add aten.bitwise_or op handler#19869
devin-lai wants to merge 1 commit into
pytorch:mainfrom
devin-lai:mlx-add-bitwise-or

Conversation

@devin-lai
Copy link
Copy Markdown

@devin-lai devin-lai commented May 29, 2026

Summary:

  • Add an MLX schema node and op handler for aten.bitwise_or Tensor and Scalar overloads.
  • Execute the node through MLX bitwise_or in the runtime interpreter.
  • Add bool, integer, and scalar op test coverage.

Fixes #18926.

Testing:

  • cmake --build cmake-out-mlx --target op_test_runner -j2
  • PATH="$PWD/.venv-mlx/bin:$PATH" .venv-mlx/bin/python -m executorch.backends.mlx.test.run_all_tests bitwise_or_bool bitwise_or_int bitwise_or_scalar --timeout 180
  • cmake --build cmake-out-mlx --target strict_compile_test -j2
  • git diff --check
  • py_compile on changed Python files
  • lintrunner --take FLAKE8,CLANGFORMAT,NEWLINE,ETCAPITAL,LICENSELINT on touched files

@devin-lai
[MLX] Add aten.bitwise_or op handler
9e822c1 
Add MLX delegate support for aten.bitwise_or Tensor and Scalar overloads, following the existing bitwise_and path through the FlatBuffer schema, Python op handler, C++ interpreter, and tests.

Fixes pytorch#18926.
@pytorch-bot
Copy link
Copy Markdown

pytorch-bot Bot commented May 29, 2026 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/19869

Note: Links to docs will display an error until the docs builds have been completed.

❗ 2 Active SEVs

There are 2 currently active SEVs. If your PR is affected, please view them below:

⚠️ 12 Awaiting Approval

As of commit 9e822c1 with merge base fb420f3 (image):

AWAITING APPROVAL - The following workflows need approval before CI can run:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label May 29, 2026
@devin-lai
Copy link
Copy Markdown
Author

devin-lai commented May 29, 2026

This PR needs a release notes: label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example @pytorchbot label "release notes: none"

For more information, see https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@pytorchbot label "release notes: apple"

@pytorch-bot pytorch-bot Bot added the release notes: apple Changes to the Apple backend delegate label May 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. release notes: apple Changes to the Apple backend delegate

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Good First Issue: Add MLX Op Handler for aten.bitwise_or

2 participants

@devin-lai @nil-is-all